Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

02-app => 01-building-your-application => 01-routing => 09-intercepting-routes.mdx 번역 #398

Merged
merged 4 commits into from
Sep 11, 2023
Merged

02-app => 01-building-your-application => 01-routing => 09-intercepting-routes.mdx 번역 #398

merged 4 commits into from
Sep 11, 2023

Conversation

JoChaeWoo
Copy link
Contributor

@JoChaeWoo JoChaeWoo commented Jul 3, 2023 •
edited
Loading

기여자용

문서 개선

Progress

@JoChaeWoo
Copy link
Contributor Author

PR이 늦어서 죄송합니다.
모자란 부분이 많다고 생각합니다. 많은 리뷰 부탁 드립니다.

@haileyport
Copy link
Contributor

ref #88

@haileyport haileyport mentioned this pull request Jul 3, 2023
Open
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jul 5, 2023
@sunmerrr sunmerrr requested review from sunmerrr and removed request for ChanghyeonYoon August 21, 2023 00:15
sunmerrr
sunmerrr reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sunmerrr sunmerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoChaeWoo LGTM! 할당 받으신 파일 외의 수정사항만 내려주시면 될 것 같습니다!:)

@ChanghyeonYoon
Copy link
Contributor

@JoChaeWoo 리뷰 이후 작업이 몇일 동안 이뤄지지 않아 9월 13일까지 작업이 없을 경우 이슈를 close하고 새로운 분에게 할당하겠습니다!

@JoChaeWoo
Copy link
Contributor Author

JoChaeWoo commented Sep 11, 2023 •
edited
Loading

@sunmerrr docs/02-app/01-building-your-application/01-routing/09-intercepting-routes.mdx 파일 외의 수정사항 revert 했습니다.
@ChanghyeonYoon 최근에 취업으로 적응하기 바빠서 활동이 원활하지 못했네요. 죄송합니다.

yoo-jimin127
yoo-jimin127 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 기여해주셔서 감사합니다 :) 👍
추가적으로 번역 희망하시는 챕터의 경우 이슈에 작성해주세요!

@yoo-jimin127 yoo-jimin127 merged commit 838e1e5 into Nextjs-kr:main Sep 11, 2023
@yoo-jimin127 yoo-jimin127 mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunmerrr sunmerrr sunmerrr left review comments

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

Assignees

@JoChaeWoo JoChaeWoo

Labels
documentation 문서 작업 In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoChaeWoo @haileyport @ChanghyeonYoon @sunmerrr @yoo-jimin127